Issue 102091 - aw065: 3D charts are broken by fix for issue 101680
Summary: aw065: 3D charts are broken by fix for issue 101680
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: wolframgarten
QA Contact: issues@graphics
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2009-05-20 12:40 UTC by IngridvdM
Modified: 2013-02-24 21:22 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description IngridvdM 2009-05-20 12:40:08 UTC 
Tthe changes in svx in svdobj.cxx revision 271718 (preventing some
recalculations when model is locked) for issue 101680 cause all 3D charts to be
broken.
Comment 1 IngridvdM 2009-05-20 13:08:12 UTC 
Armin, this regression should be fixed before CWS aw065 goes to QA. Let me know
when I am supposed to change the Draw-API usage now.
Comment 2 Armin Le Grand 2009-06-05 12:18:06 UTC 
AW: Checked if really the suppression when model is locked is the reason for 3D
to disappear: Interestingly, it's not the suppression at
SdrObject::RecalcBoundRect(), but the one at SdrObject::ActionChanged(). This is
surprisong since during a model construction, no VOCs should exist and thus,
executing ActionChanged() or not should not make a difference. Need to check
what changes here, adding debug code to svx and drawinglayer...
Also found an error in ScenePrimitive2D::get2DDecomposition; the local
remembrance of the visible area does not work for the first run, corrected this.
Comment 3 Armin Le Grand 2009-06-05 13:16:22 UTC 
AW: A lot of stuff is interfering here; IHA already talked about
SdrOle2Obj::executeOldDoPaintPreparations() which calls GetGraphic() at the OLE
and thus triggers a new model with chart to metafile rendering; it's also the
fact that SdrObject::ActionChanged() resets the BoundRects at the VOCs. All in
all i will need a more stable/cleanedup version to do more (e.g. create an OLE
primitive which does not already have the Graphic, but holds the
svt::EmbeddedObjectRef or needed stuff to get the Graphic in it's decompose and
implements a getB2DRange() locally).
For the moment i will just remove the suppression on model lock for
SdrObject::ActionChanged().
Comment 4 Armin Le Grand 2009-06-05 13:55:38 UTC 
AW: Okay, removed. 3D works as before for the moment.
Comment 5 Armin Le Grand 2009-06-09 10:58:49 UTC 
AW->WG: Please verify. Test is just a simple 3D chart, save, load.
Comment 6 wolframgarten 2009-06-11 13:42:19 UTC 
Verified in CWS.
Comment 7 wolframgarten 2009-07-21 09:53:28 UTC 
Tested in m52. Closed.