Issue 102950 - charts in writer have an incomplete border
Summary: charts in writer have an incomplete border
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: sgautier.ooo
QA Contact: issues@graphics
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2009-06-19 15:09 UTC by IngridvdM
Modified: 2013-02-24 21:20 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
picture showing the problem (3.50 KB, image/png)
2009-06-19 15:11 UTC, IngridvdM
no flags Details
example documentwith different charts (40.17 KB, application/vnd.oasis.opendocument.text)
2009-06-19 15:19 UTC, IngridvdM
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description IngridvdM 2009-06-19 15:09:13 UTC
Create a chart within a writer document and leave the charts edit mode by
clicking somewhere in the text document besides the chart. With OOo 3.1 the
chart now shows a gray border line at the left and top edge. This looks ugly and
incomplete. There was no border visible with OOo 3.0. I'll attach a picture to
illustrate.
Comment 1 IngridvdM 2009-06-19 15:11:10 UTC
Created attachment 63093 [details]
picture showing the problem
Comment 2 IngridvdM 2009-06-19 15:18:48 UTC
I will fix that problem by simply not painting those additional lines in case of
charts within SwFlyFrm::Paint.
I think this is the best solution as the chart can be partly transparent,
dependent on what area and border settings are made within the chart. Then it
can happen that the additional border lines from the writer do overlap with the
dashed border of the chart. That again looks ugly.
I'll attach an example with charts with different area and border settings.
Comment 3 IngridvdM 2009-06-19 15:19:49 UTC
Created attachment 63095 [details]
example documentwith different charts
Comment 4 Oliver-Rainer Wittmann 2009-06-19 15:25:07 UTC
OD->IHA:
Suppressing the additional lines is a possible solution.
But, I am asking myself, what code change was caused the change in the painting
of embedded objects. If you have something ready for debug, I would like to join
you.
Comment 5 Oliver-Rainer Wittmann 2009-06-19 15:29:03 UTC
OD->IHA:
It looks like, that the area taken by the embedded object's output is too large.
In general it should inside the object's border rectangle and should not overlap
with the border illustrating the size of the embedded object.
Comment 6 IngridvdM 2009-06-19 15:49:39 UTC
IHA->OD: Thanks for the offer :-). The problem was introduced by the new
Anti-Aliasing feature. When switching off Anti-Aliasing under
Tools->Options->View the additional borders do vanish. I have tricked around
already a lot, but gained the most satisfying results with simply switching off
the borders.
Comment 7 IngridvdM 2009-06-22 09:56:08 UTC
IHA->OD: As discussed off line we will take the simple solution for charts. If
it happens that other OLE objects might show similar problems with the gray
subsidiary lines in future it might be a good idea to set the flag
ANTIALIASING_PIXELSNAPHAIRLINE for the antialiasing mode while painting those
lines in SwSubsRects::PaintSubsidiary. But that could be a different issue.

Fixed in CWS chart39. For charts no subsidiary lines are shown now as it was
with OOo 3.0 and before.
Comment 8 IngridvdM 2009-07-01 13:49:00 UTC
@Sophie, please verify in CWS chart39. Thanks!
Make sure to have Anti-Aliasing on on your Office
(Tools->Options->StarOffice->View->Use Anti-Aliasing). Load the attached example
ChartBordersInWriter.odt and display the document with different zoom factors.
There should be no gray borders around the charts (only some green dashed
borders for some of them).
Comment 9 sgautier.ooo 2009-07-02 12:09:41 UTC
Verified in CWS chart39 - No grey borders using different zoom and layout, also
ok when zooming in preview. Sophie.
Comment 10 sgautier.ooo 2009-08-05 13:50:25 UTC
Verified in DEV300m54 under .deb version - Closing - Sophie