Issue 103713 - chart2: ambiguous && ||
Summary: chart2: ambiguous && ||
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: caolanm
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks: 96084
  Show dependency tree
 
Reported: 2009-07-22 09:08 UTC by caolanm
Modified: 2013-02-24 21:21 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch to make current logic explicit (692 bytes, patch)
2009-07-22 09:08 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2009-07-22 09:08:35 UTC 
There's a little ambiguity in lcl_maybeReplaceNanWithZero that newer gcc's warn
about. Is the intention the same as the operator precedence in there, i.e. the
following patch makes explicit what we're current doing, this it the intention
right ?
Comment 1 caolanm 2009-07-22 09:08:59 UTC 
Created attachment 63681 [details]
patch to make current logic explicit
Comment 2 IngridvdM 2009-07-22 09:29:23 UTC 
Ah, thanks for pointing that out. In fact it should be the other way round. I
corrected that in CWS chart40.
Comment 3 IngridvdM 2009-07-22 09:30:13 UTC 
@cmc, please verify in CWS chart40.
Comment 4 caolanm 2009-07-22 09:42:06 UTC 
excellent, bug detected early.
Comment 5 caolanm 2009-09-16 10:31:37 UTC 
close, integrated