Issue 104769 - Chart from xls doc fails to update on value change.
Summary: Chart from xls doc fails to update on value change.
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: open-import (show other issues)
Version: DEV300m56
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: kla
QA Contact: issues@sc
URL: https://bugzilla.novell.com/show_bug....
Keywords:
Depends on: 104867
Blocks:
  Show dependency tree
 
Reported: 2009-09-03 21:46 UTC by kyoshida
Modified: 2013-08-07 15:14 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
test document (13.50 KB, application/vnd.ms-excel)
2009-09-03 21:47 UTC, kyoshida 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description kyoshida 2009-09-03 21:46:59 UTC 
When loading an xls document with embedded chart into Calc, Calc fails to update
the chart on value change, when the source data consists of formula cells
outside the visible area.  I'll attach a test document to demonstrate the problem.
Comment 1 kyoshida 2009-09-03 21:47:39 UTC 
Created attachment 64534 [details]
test document
Comment 2 kyoshida 2009-09-03 21:50:35 UTC 
The chart in the document references cell A100 for its data, which is a formula
cell that in turn references cell A1.  Change the value of A1, chart doesn't get
updated.

Now, scroll down so that cell A100 is visible, then scroll it back up to cell
A1, then change the value of A1.  This time, chart gets updated.
Comment 3 kyoshida 2009-09-03 21:51:29 UTC 
We have a fix for this on Go-OO.  I'll port the fix to kohei03 cws, hopefully
for 3.2.
Comment 4 kyoshida 2009-09-03 22:23:41 UTC 
fixed this in kohei03 cws: 
http://hg.services.openoffice.org/hg/cws/kohei03/rev/9de860ec875a
Comment 5 niklas.nebel 2009-09-08 17:59:16 UTC 
With the change to SetDirtyAfterLoad, the additional chart listener seems
unnecessary. But we have to check if setting the bDirty flag really isn't needed
in all cases.
Comment 6 niklas.nebel 2009-09-08 19:31:51 UTC 
See also issue 104899, which is somewhat related (it's not the same - there the
formulas still have their initial dirty state if row heights aren't updated).
Comment 7 kyoshida 2009-10-19 23:01:16 UTC 
I've reverted the change related to the dirty flag in ScFormulaCell, since it
was not related to this fix.

http://hg.services.openoffice.org/cws/kohei03/rev/c5d669ab8749
Comment 8 kyoshida 2009-12-19 01:55:32 UTC 
re-assigning for qa verification.
Comment 9 kyoshida 2010-01-27 21:06:16 UTC 
http://hg.services.openoffice.org/hg/cws/kohei03/rev/74bfd1f248be

Ok.  My previous fix was insufficient.  I made the above change to fix this for
real.
Comment 10 kla 2010-02-05 10:04:29 UTC 
Seen ok in cws kohei03 -> verified
Comment 11 wope 2010-05-01 21:25:06 UTC 
ok in DEV300m77, issue closing
Comment 12 niklas.nebel 2010-07-01 16:46:04 UTC 
This fix doesn't always work, see issue 112436.