Issue 112500 - WaE: chart2/source/tools/DiagramHelper.cxx
Summary: WaE: chart2/source/tools/DiagramHelper.cxx
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: pavel
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-18 09:37 UTC by pavel
Modified: 2017-05-20 11:41 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2010-06-18 09:37:13 UTC 
Compiling: chart2/source/tools/DiagramHelper.cxx
cc1plus: warnings being treated as errors
/home/oo/BuildDir/ooo_DEV300_m83_src/chart2/source/tools/DiagramHelper.cxx: In static member 
function 'static com::sun::star::awt::Rectangle 
chart::DiagramHelper::getDiagramRectangleFromModel(const 
com::sun::star::uno::Reference<com::sun::star::frame::XModel>&)':
/home/oo/BuildDir/ooo_DEV300_m83_src/chart2/source/tools/DiagramHelper.cxx:1517: warning: 
passing 'double' for argument 1 to 'com::sun::star::awt::Size::Size(const sal_Int32&, const sal_Int32&)'
/home/oo/BuildDir/ooo_DEV300_m83_src/chart2/source/tools/DiagramHelper.cxx:1517: warning: 
passing 'double' for argument 2 to 'com::sun::star::awt::Size::Size(const sal_Int32&, const sal_Int32&)'
Comment 1 pavel 2010-06-18 09:38:57 UTC 
Proposed fix:

    awt::Size aAbsSize(
        static_cast< sal_Int32 >(aRelSize.Primary * aPageSize.Width),
        static_cast< sal_Int32 >(aRelSize.Secondary * aPageSize.Height) );
Comment 2 IngridvdM 2010-06-22 10:06:35 UTC 
taking issue
Comment 3 IngridvdM 2010-10-08 10:23:40 UTC 
Fixed in CWS chart49.
Comment 4 IngridvdM 2010-10-08 16:37:06 UTC 
pjanik, please verify in CWS chart49:
http://hg.services.openoffice.org/cws/chart49/rev/c57ece86cb42
Thanks!
Comment 5 pavel 2010-10-08 16:56:27 UTC 
verified