Issue 113950 - ODF: text:id has a bad value
Summary: ODF: text:id has a bad value
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P2 Trivial (vote)
Target Milestone: ---
Assignee: kla
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks: 111112
  Show dependency tree
 
Reported: 2010-08-17 19:23 UTC by aguelzow
Modified: 2013-02-24 21:20 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
sample spreadsheet file (17.60 KB, application/vnd.oasis.opendocument.spreadsheet)
2010-08-17 19:23 UTC, aguelzow
no flags Details
file showing the newly introduced unavoidable problem - just for reference (12.97 KB, application/vnd.oasis.opendocument.spreadsheet)
2010-08-27 12:05 UTC, IngridvdM
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description aguelzow 2010-08-17 19:23:02 UTC
I will be attaching a file that was created in:
OpenOffice.org 3.2.0 OOO320m12 from the ubuntu distribution

When sending the file (a pretty simple one in fact) through the validator at
http://tools.odftoolkit.org/odfvalidator/ I get:

upload:///ring-ooo.ods/styles.xml[2,2058]:Error:attribute "style:decimal-places"
has a bad value: "-1" does not satisfy the "nonNegativeInteger" type
upload:///ring-ooo.ods/Object 1//Object 1/content.xml[2,4866]:Error:element
"chart:chart" is missing "type" attribute
upload:///ring-ooo.ods/Object 1//Object 1/content.xml[2,6718]:Error:attribute
"text:id" has a bad value: "Sheet1.A2:Sheet1.A4" does not satisfy the "NCName" type
upload:///ring-ooo.ods/Object 1//Object 1/content.xml[2,6848]:Error:attribute
"text:id" has a bad value: "Sheet1.B2:Sheet1.B4" does not satisfy the "NCName" type
upload:///ring-ooo.ods/Object 1//Object 1/content.xml[2,6976]:Error:attribute
"text:id" has a bad value: "Sheet1.C2:Sheet1.C4" does not satisfy the "NCName" type
upload:///ring-ooo.ods:Info:validation errors found
upload:///ring-ooo.ods:Info:Generator: OpenOffice.org/3.2$Linux
OpenOffice.org_project/320m12$Build-9483
Comment 1 aguelzow 2010-08-17 19:23:43 UTC
Created attachment 71148 [details]
sample spreadsheet file
Comment 2 Olaf Felka 2010-08-18 07:51:22 UTC
@ aguelzow: Can you reproduce this problem with the native OOo 3.2.1?
Comment 3 aguelzow 2010-08-18 19:43:58 UTC
I don't really know what "native OOo 3.2.1" means other than to use a slightly
newer version. 

In any case the file should be easy to recreate in any version. There is nothing
strange or special I did but just asked for the appropriate chart style.
Comment 4 aguelzow 2010-08-19 06:18:16 UTC
The readme file in the OOo download at openoffice.org calls the version included
in the OS distributions the native version, versus the community version
downloadable at openoffice.org. That would mean that I used the native version
(and 3.2.0 is the newest available in ubuntu).
Comment 5 ooo 2010-08-20 14:36:15 UTC
This seems to be a misunderstanding. I guess with "native" version 'of' was
referring to the original upstream version instead of any distribution's
package.

I loaded and saved the attached document in OOO330m3 and ran the validator on
it:

upload:///ring-ooo.ods/Object 1//Object 1/content.xml[2,4866]:Error:element "chart:chart" is missing "type" attribute
upload:///ring-ooo.ods/Object 1//Object 1/content.xml[2,6718]:Error:attribute "text:id" has a bad value: "Sheet1.A2:Sheet1.A4" does not satisfy the "NCName" type
upload:///ring-ooo.ods/Object 1//Object 1/content.xml[2,6848]:Error:attribute "text:id" has a bad value: "Sheet1.B2:Sheet1.B4" does not satisfy the "NCName" type
upload:///ring-ooo.ods/Object 1//Object 1/content.xml[2,6976]:Error:attribute "text:id" has a bad value: "Sheet1.C2:Sheet1.C4" does not satisfy the "NCName" type
upload:///ring-ooo.ods:Info:validation errors found
upload:///ring-ooo.ods:Info:Generator: OpenOffice.org/3.3$Solaris_x86 OpenOffice.org_project/330m3$Build-9519

So the style:decimal-places error is not present, but the chart errors remain.

Reassigning to 'tbe'.
Comment 6 Oliver Brinzing 2010-08-23 07:31:01 UTC
.
Comment 7 thomas.benisch 2010-08-23 09:44:09 UTC
TBE->IHA: Please take over.
Comment 8 IngridvdM 2010-08-23 10:00:07 UTC
The error regarding the missing type attribute was fixed already with issue
110355 for target OOo 3.3. Remains the error with text:id.
Comment 9 IngridvdM 2010-08-25 13:59:22 UTC
I will need to change the implementation because the ODF specification has
changed incompatible. In previous ODF versions the text:id was allowed to be an
arbitrary string.
Comment 10 IngridvdM 2010-08-27 12:02:09 UTC
The export of the text:id element was introduced with issue 366, to be able to
copy/paste charts with error ranges from calc to e.g. impress. It holds the
information from which original range the data in the local table was received.
With this information the data can be mapped to the correct chart elements after
switching to local data on paste.
The range information is now exported to the description of an empty draw:group.
Not elegant, but ODF conform and it should not hurt any other application
reading ODF as the whole table is irrelevant in this scenario (checked Gnumeric
and Xcel).

One problem comes for OOo with the fix and cannot be avoided:
If a new file containing error bars from ranges is opened with an old office
version, the copy/paste action will fail as long as the document is not modified.

Fixed as described within CWS chart50:
http://hg.services.openoffice.org/cws/chart50/rev/47203f31f317

Comment 11 IngridvdM 2010-08-27 12:05:20 UTC
Created attachment 71424 [details]
file showing the newly introduced unavoidable problem - just for reference
Comment 12 IngridvdM 2010-08-27 21:25:21 UTC
@Thomas, please verify in CWS chart50.
Comment 13 thomas.benisch 2010-08-31 14:44:47 UTC
set target OOo 3.3
Comment 14 kla 2010-09-03 14:21:32 UTC
Seen ok in cws chart 50 -> verified
Comment 15 kla 2010-12-29 16:02:49 UTC
closed