Issue 26654 - build fails in sch with preprocessor error (non-product build)
Summary: build fails in sch with preprocessor error (non-product build)
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: bjoern.milcke
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-18 09:14 UTC by mkretzschmar
Modified: 2013-02-24 21:22 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch (change ##w to #w) (1.58 KB, patch)
2004-03-18 09:15 UTC, mkretzschmar 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description mkretzschmar 2004-03-18 09:14:32 UTC 
Using gcc.real (GCC) 3.3.3 (Debian)

and cws_src680_ooo20040329 I get errors like this

openoffice.org-src680_ooo20040329/sch/source/ui/func/fudatrow.cxx:139:61:
pasting ""SCH(%lx):"" and ""SchFuDataRowPoint::SchFuDataRowPoint"" does not give
a valid preprocessing token

The Problem lies in the CHART_TRACE* macros.

#define CHART_TRACE(  w ) DBG_TRACE1( "SCH(%lx):" ##w, (long)this )

Preprocessing x##y yields xy where x, y, and xy are tokens.

Preprocessing #y yields "y", thus "foo" #bar yields "foo" "bar", i.e. "foobar".

Thus #w is needed, not ##w.
Comment 1 mkretzschmar 2004-03-18 09:15:13 UTC 
Created attachment 13892 [details]
Patch (change ##w to #w)
Comment 2 kla 2004-03-18 09:41:37 UTC 
Hi Bjoern,
pls have a look.
Comment 3 bjoern.milcke 2004-05-17 08:01:48 UTC 
Patch applied
Comment 4 jogi 2004-07-12 14:08:40 UTC 
Target was wrong.
Comment 5 ooo 2004-07-12 14:26:07 UTC 
verified
Comment 6 bjoern.milcke 2004-07-27 10:34:31 UTC 
Patch applied in build SRC680m48.
Comment 7 bjoern.milcke 2004-07-27 10:37:35 UTC 
.
Comment 8 bjoern.milcke 2004-07-27 10:40:17 UTC 
Closing as patch was successfully applied.