Issue 40168 - 64bit: SetMaximumNumberOfLines and long vs. sal_Int32
Summary: 64bit: SetMaximumNumberOfLines and long vs. sal_Int32
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: PC (x86_64) All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: pavel
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-07 21:57 UTC by pavel
Modified: 2013-02-24 21:22 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2005-01-07 21:57:07 UTC 
Hi,

please unify this:

Prototype:
source/controller/inc/dlg_ChartType.hxx:
   void SetMaximumNumberOfLines( sal_Int32 nMaxLines );

Definition:
source/controller/dialogs/dlg_ChartType.cxx:
   void SchDiagramTypeDlg::SetMaximumNumberOfLines( long nMaxLines )

long !=sal_Int32 on 64bit platforms.
Comment 1 IngridvdM 2005-01-12 17:43:43 UTC 
I will have a look.
Comment 2 pavel 2005-01-21 14:52:52 UTC 
I'll commit this change into ooo64bit02:

--- dlg_ChartType.cxx	8 Sep 2004 17:01:22 -0000	1.8
+++ dlg_ChartType.cxx	21 Jan 2005 14:52:07 -0000
@@ -1258,7 +1258,7 @@
     }
 }
 
-void SchDiagramTypeDlg::SetMaximumNumberOfLines( long nMaxLines )
+void SchDiagramTypeDlg::SetMaximumNumberOfLines( sal_Int32 nMaxLines )
 {
     aMtrFldNumLines.SetLast( nMaxLines );
     aMtrFldNumLines.SetMax( nMaxLines );

if you agree with this change, please mark this as FIXED. Thanks.
Comment 3 IngridvdM 2005-01-21 16:31:10 UTC 
The code you changed will vanish completly with the next integration of the
major chart2 branch (which is cws_src680_chart2mst3 currently ). So your change
will do no harm anyway, only maybe merge conflicts. I think we get them
resolved, so I set this to fixed now. If you would like to take the issue back
to you I'm fine with that also. Thanks.
Comment 4 IngridvdM 2005-01-21 16:40:10 UTC 
->pjanik: Please do not forget to checkin the dialog header changes also to
ooo64bit02.
Comment 5 IngridvdM 2005-02-04 18:14:35 UTC 
reopen for reassign
Comment 6 IngridvdM 2005-02-04 18:17:41 UTC 
->pjanik: I give this back to you, as you did the fix anyway. And again: don't
forget to check in the header changes also! :-) Thanks.
Comment 7 pavel 2005-02-16 20:01:52 UTC 
iha: no header change is needed. What do you mean by it?

With this change, the definition of this function actually matches its declaration.

Fixed in ooo64bit02.
Comment 8 IngridvdM 2005-02-17 08:52:22 UTC 
->pjanik: Oh yes, you are right, there is nothing needed anymore. My fault  -
sorry. And thanks again.
Comment 9 pavel 2006-05-01 10:56:06 UTC 
Closing.