Issue 56310 - Binary saved Charts with Calc data lose connection
Summary: Binary saved Charts with Calc data lose connection
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: kla
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-20 10:57 UTC by bjoern.milcke
Modified: 2013-02-24 21:21 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description bjoern.milcke 2005-10-20 10:57:59 UTC 
1. Create a Spreadsheet with some data and create a chart out of this data
2. Save as 5.0 (.sdc) file
3. reload in SO 5.2, SO 7 or current version
=> Changes of data in Calc have no effect on the chart. You can also not edit
the data with the chart data editor.
Workaround: drag the original source data range onto the chart.
Comment 1 bjoern.milcke 2005-10-20 11:01:25 UTC 
changed owner to me
Comment 2 bjoern.milcke 2005-12-14 15:52:51 UTC 
I finally found the problem.

First, binfilter does a binary SaveAs at the SchChartDocShell. However, the
saved document is a default one not the one that should be saved. This lead me
into a wrong direction while trying to find the problem.

Then after the new XML stream (OASIS) was converted to the old XML format (OOo)
and this stream was read via binfilter, the binary save is done via Save. In the
Save code there was no special handling for converting the ChartRange at the
SchMemChart into the Writer- and Calc-specific settings of the SomeData strings.

The fix just adds the conversion done in SaveAs also to Save.
Comment 3 bjoern.milcke 2005-12-20 12:53:41 UTC 
Please verify. To test, change some data in the spreadsheet and check, if the
chart changes accordingly, and take a look at the range via "Modify
Datarange..." (in the broken version only "A1" is shown).

re-open issue and reassign to kla
Comment 4 bjoern.milcke 2005-12-20 12:54:07 UTC 
reassign to kla
Comment 5 bjoern.milcke 2005-12-20 12:54:18 UTC 
reset resolution to FIXED
Comment 6 IngridvdM 2006-01-02 17:35:39 UTC 
reopen as the fix is not contained in the patch so far
Comment 7 IngridvdM 2006-01-02 17:37:45 UTC 
i will take over as bm is on vacation
Comment 8 IngridvdM 2006-01-03 15:32:50 UTC 
the binfilter chart lib was missing in the patch.
Comment 9 IngridvdM 2006-01-04 16:58:18 UTC 
ready for verification in CWS sch13

re-open issue and reassign to kla@openoffice.org
Comment 10 IngridvdM 2006-01-04 16:58:37 UTC 
reassign to kla@openoffice.org
Comment 11 IngridvdM 2006-01-04 16:58:44 UTC 
reset resolution to FIXED
Comment 12 kla 2006-01-12 15:00:22 UTC 
ok in CWS sch13 -> verified
Comment 13 kla 2006-01-25 11:08:15 UTC 
ok in master -> closed