Apache OpenOffice (AOO) Bugzilla – Issue 62430
64bit: mismatch between set and get RowTranslation
Last modified: 2013-02-24 21:21:41 UTC
SetRowTranslation uses sal_Int32*, while GetRowTranslation uses long*, which are currently the same for 32bit, but are different for 64bit. defined in sch/memchrt.hxx A patch attached to translate as things currently are in sc where it is used, but which way do you want this fixed, both long*, or both sal_Int32* ?
Created attachment 34378 [details] workaround patch
@bm: I think its for you.
Created attachment 34890 [details] patch for review
how about this as the final preferred solution ? Make consistently use sal_Int32, i.e. no change at all from current implied 32bit situation. If you're ok with this change, return it to me and I can take care of committing it.
-> cmc: Sorry, for not taking care of this issue. As we are re-writing the chart, I am a bit lazy about issues concerning sch. Well, the inconsistent usage of different types (sal_Int32, long, USHORT, short, ...) in the chart has always been a pain, but never enough of a pain to fix it ... Your patch looks good. If you take care about committing the changes, that would be great. Go ahead, and thanks!
One additional comment: Did you make sure that this stuff is not used in Writer? It might also be used there, but I am not sure about this. (I suppose you checked, anyway)
excellent, committed to sixtyfour04, writer is ok from this perspective.
Verified.
in m163