Issue 63011 - new chart: gcc 4 : "explicit qualification in declaration"
Summary: new chart: gcc 4 : "explicit qualification in declaration"
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: bjoern.milcke
QA Contact: issues@graphics
URL:
Keywords: new_implementation
Depends on:
Blocks:
 
Reported: 2006-03-10 12:21 UTC by pagalmes.lists
Modified: 2013-02-24 21:21 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
diff for the issue (1.14 KB, patch)
2006-03-10 12:24 UTC, pagalmes.lists
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description pagalmes.lists 2006-03-10 12:21:29 UTC
Hello,

while compiling the new chart module, an error appeared :


Making: ../../unxlngi6/slo/DataSeriesHelper.obj
g++ -Wreturn-type -fmessage-length=0 -c -I.  -I. -I../inc -I../../source/inc
-I../../inc -I../../unx/inc -I../../unxlngi6/inc -I.
-I/home/pagalmes/workspace/OpenOffice/solver/680/unxlngi6/inc/stl
-I/home/pagalmes/workspace/OpenOffice/solver/680/unxlngi6/inc/external
-I/home/pagalmes/workspace/OpenOffice/solver/680/unxlngi6/inc
-I/home/pagalmes/workspace/OpenOffice/solenv/unxlngi6/inc
-I/home/pagalmes/workspace/OpenOffice/solenv/inc
-I/home/pagalmes/workspace/OpenOffice/res
-I/home/pagalmes/workspace/OpenOffice/solver/680/unxlngi6/inc/stl
-I/home/pagalmes/workspace/OpenOffice/solenv/inc/Xp31
-I/opt/j2sdk1.4.2_09/include -I/opt/j2sdk1.4.2_09/include/linux
-I/opt/j2sdk1.4.2_09/include/native_threads/include -I/usr/X11R6/include     -I.
-I../../res -I. -g  -O0   -pipe -mtune=pentiumpro -Wno-ctor-dtor-privacy
-fvisibility-inlines-hidden -g -fexceptions -fno-enforce-eh-specs   -fpic
-DLINUX -DUNX -DVCL -DGCC -DC341 -DINTEL -D_STLP_DEBUG -DCVER=C341
-D_USE_NAMESPACE -DNPTL -DGLIBC=2 -DX86 -D_PTHREADS -D_REENTRANT -DNEW_SOLAR
-D_USE_NAMESPACE=1 -DSTLPORT_VERSION=400 -DHAVE_GCC_VISIBILITY_FEATURE -D__DMAKE
-DUNIX -DCPPU_ENV=gcc3
-DGXX_INCLUDE_PATH=/usr/lib/gcc/i386-redhat-linux/4.0.2/../../../../include/c++/4.0.2
-DSUPD=680 -DDEBUG -DDBG_UTIL -DOSL_DEBUG_LEVEL=2 -DEXCEPTIONS_ON -DCUI
-DSOLAR_JAVA -DSRC680=SRC680   -DSHAREDLIB -D_DLL_  -DMULTITHREAD  -o
../../unxlngi6/slo/DataSeriesHelper.o
/home/pagalmes/workspace/OpenOffice/chart2/source/tools/DataSeriesHelper.cxx
/home/pagalmes/workspace/OpenOffice/chart2/source/tools/DataSeriesHelper.cxx:298:
erreur: explicit qualification in declaration of `chart::StackMode
chart::DataSeriesHelper::getStackModeFromSeries(const
com::sun::star::uno::Sequence<com::sun::star::uno::Reference<com::sun::star::chart2::XDataSeries>
>&, const
com::sun::star::uno::Reference<com::sun::star::chart2::XCoordinateSystem>&)'
/home/pagalmes/workspace/OpenOffice/chart2/source/tools/DataSeriesHelper.cxx:387:
erreur: explicit qualification in declaration of `void
chart::DataSeriesHelper::setStackModeAtSeries(const
com::sun::star::uno::Sequence<com::sun::star::uno::Reference<com::sun::star::chart2::XDataSeries>
>&, const
com::sun::star::uno::Reference<com::sun::star::chart2::XCoordinateSystem>&,
chart::StackMode)'
dmake:  Error code 1, while making '../../unxlngi6/slo/DataSeriesHelper.obj'
'---* tg_merge.mk *---'

ERROR: Error 65280 occurred while making
/home/pagalmes/workspace/OpenOffice/chart2/source/tools


The related file is :
/home/pagalmes/workspace/OpenOffice/chart2/source/tools/DataSeriesHelper.cxx

The errors are related to the new version of gcc which is more strict than the
previous versions. Have a look at the following page :
http://wiki.services.openoffice.org/wiki/Writing_correct_Cplusplus#Extra_Qualification

So, the code line 298 and 384 have to be changed :

StackMode DataSeriesHelper::getStackModeFromSeries(
->
StackMode getStackModeFromSeries(

and :

void DataSeriesHelper::setStackModeAtSeries(
->
void setStackModeAtSeries(

I also noticed another small mistake on line 51 :
#include <com/sun/star/chart2/data/LabelOrigin.hpp

moved to :
#include <com/sun/star/chart2/data/LabelOrigin.hpp>


You can find the patch enclosed.

Regards,
Comment 1 wolframgarten 2006-03-10 12:24:21 UTC
Changing component.
Comment 2 pagalmes.lists 2006-03-10 12:24:41 UTC
Created attachment 34726 [details]
diff for the issue
Comment 3 wolframgarten 2006-03-10 12:25:12 UTC
Reassigned.
Comment 4 kla 2006-03-10 12:38:00 UTC
@bm: Seem to be yours.
Comment 5 bjoern.milcke 2006-03-10 12:59:09 UTC
Taking over
Comment 6 bjoern.milcke 2006-03-10 13:06:10 UTC
patch applied
Comment 7 IngridvdM 2006-03-22 09:08:54 UTC
changed summary to start with 'new chart: ' to avoid confusion with regular
chart bugs
Comment 8 bjoern.milcke 2006-06-23 10:02:57 UTC
Changed target to 2.x
Comment 9 bjoern.milcke 2006-12-13 17:30:55 UTC
patch is applied. Verified.
Comment 10 bjoern.milcke 2006-12-13 17:31:59 UTC
Closing as this happened only on  the CWS. If there are other compiler issues
after integration, we need separate issues anyway.