Issue 66818 - Regression curves: Tons of assertions in dialog
Summary: Regression curves: Tons of assertions in dialog
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: daniel.rentz
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-28 11:55 UTC by daniel.rentz
Modified: 2013-02-24 21:20 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for removing the mentioned assertions (3.60 KB, patch)
2007-08-01 16:35 UTC, bjoern.milcke 		no flags Details | Diff
Revised version of the patch (3.21 KB, patch)
2007-08-15 15:46 UTC, bjoern.milcke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description daniel.rentz 2006-06-28 11:55:18 UTC 
Insert a line or XY chart with a regression curve. Open the object format 
dialog of the curve - tons of assertions. (Must be a line type chart, no 
problems in a bar chart.)
Comment 1 daniel.rentz 2006-06-28 11:55:31 UTC 
target
Comment 2 bjoern.milcke 2007-03-28 10:18:44 UTC 
Some of the failed assertions:

Error:  - unknown Property: BorderStyle From File
D:\chart2mst3\SRC680\chart2\source\controller\itemsetwrapper\ItemConverter.cxx
at Line 164
Error:  - unknown Property: FillBitmapRectanglePoint From File
D:\chart2mst3\SRC680\chart2\source\controller\itemsetwrapper\ItemConverter.cxx
at Line 164
Error:  - unknown Property: CharColor From File
D:\chart2mst3\SRC680\chart2\source\controller\itemsetwrapper\ItemConverter.cxx
at Line 164
Error:  - unknown Property: Geometry3D From File
D:\chart2mst3\SRC680\chart2\source\controller\itemsetwrapper\ItemConverter.cxx
at Line 164

This looks like the dialog item converter expects the regression curve (or the
series?) to be a filled data series (like the series of a bar chart).
Comment 3 bjoern.milcke 2007-08-01 16:02:13 UTC 
Fixed in SRC680.m223.

->DR: Please verify.
Comment 4 bjoern.milcke 2007-08-01 16:02:53 UTC 
setting to fixed.
Comment 5 bjoern.milcke 2007-08-01 16:09:45 UTC 
Oops, sorry, checked the wrong chart type. Seems indeed only to happen for
scatter charts.
Comment 6 bjoern.milcke 2007-08-01 16:11:08 UTC 
Still occurs for scatter charts.
Comment 7 bjoern.milcke 2007-08-01 16:35:20 UTC 
Created attachment 47254 [details]
Patch for removing the mentioned assertions
Comment 8 bjoern.milcke 2007-08-01 16:38:56 UTC 
->iha: Please have a look at the patch. It resolves the assertions, and I think
the fix is correct, however I am not so familiar with the code, so you should
verify this.

* I presume The "has-" properties that are generated by the ChartTypeHelper are
probably only relevant for data points and series, right?

* The check if type == series or _label_ seems to be wrong, and should rather be
if type == series or _point_, alsot right?
Comment 9 bjoern.milcke 2007-08-01 16:43:52 UTC 
Ok, already found one problem: secondary axis makes no sense for data points,
however does it for labels?
Comment 10 IngridvdM 2007-08-01 17:13:21 UTC 
all the properties that were in the brackets were not offered for single
datapoints before
m_bHasStatisticProperties, m_bHasRegressionProperties,        
m_bProvidesSecondaryYAxis, m_bProvidesOverlapAndGapWidth 
This should be changed back.
The data labels so far lead to the same properties dialog as the series. This is
ok as long as the label settings like font etc, are all in the series properties
dialog.
The same yields for a single label and a single point.
Comment 11 bjoern.milcke 2007-08-15 15:46:47 UTC 
Created attachment 47544 [details]
Revised version of the patch
Comment 12 bjoern.milcke 2007-08-15 15:47:47 UTC 
I attached a new version of the patch and also committed these changes in CWS
chart11.

->iha: Please verify that the changes are correct now.
Comment 13 bjoern.milcke 2007-08-15 17:09:21 UTC 
adapting target
Comment 14 bjoern.milcke 2007-09-05 15:11:34 UTC 
->dr: please verify in CWS chart11.
Comment 15 daniel.rentz 2007-09-11 12:39:51 UTC 
verified
Comment 16 daniel.rentz 2007-12-11 09:03:13 UTC 
closed