Issue 68229 - New chart: Adapt table::XTableCharts and sheet::XTableChart in Calc to use the new Chart
Summary: New chart: Adapt table::XTableCharts and sheet::XTableChart in Calc to use th...
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: bjoern.milcke
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-07 14:36 UTC by bjoern.milcke
Modified: 2013-02-24 21:22 UTC (History)
2 users (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Test Document using the XTableChart interface (33.22 KB, application/vnd.oasis.opendocument.spreadsheet)
2007-02-01 16:17 UTC, bjoern.milcke 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description bjoern.milcke 2006-08-07 14:36:00 UTC 
A sheet::Spreadsheet from Calc supports the sheet::XTableChartsSupplier. If you
call getCharts() at this interface, you get a collection of charts, at which you
can add charts or query charts for their content. The adding of charts has to be
adapted to use the new chart.

Also the XTableChart has to be adapted to the new chart.
Comment 1 bjoern.milcke 2006-08-07 14:37:05 UTC 
Reassigning back to me.
Comment 2 bjoern.milcke 2006-08-15 10:39:06 UTC 
Also fixed: there was a missing setVisualAreaSize() call, so that the newly
added charts always had 7cm x 8cm VisArea. (Also appears in the old Chart).

Should be fixed, but have to check all methods offered yet.
Comment 3 IngridvdM 2007-01-18 11:47:17 UTC 
changed target to 2.3
Comment 4 bjoern.milcke 2007-02-01 16:17:53 UTC 
Created attachment 42637 [details]
Test Document using the XTableChart interface
Comment 5 bjoern.milcke 2007-02-02 16:43:44 UTC 
Fixed so far. However, there remains one problem. When you try to get the values
for "first row as labels" and "first column as labels", you sometimes get the
wrong values.

->NN: Please have a look at chartuno.cxx: GetData_Impl. This calls a static
method ScChart2DataProvider::detectArguments() method (see chart2uno.cxx) that
retrieves different values than the detectArguments API-function at the same class.

In the attached file, starting the macro should show "False" as first value, not
"True". (The macro is placed in the "Legend" tab for historical reasons).

Make sure you update chart2 before starting, as I checked in another change
today, that influences the return value of getUsedData().
Comment 6 niklas.nebel 2007-02-15 17:51:22 UTC 
The variables weren't initialized. Fixed with chart2uno.cxx 1.2.10.54.
Comment 7 niklas.nebel 2007-02-19 15:17:00 UTC 
back for verification
Comment 8 bjoern.milcke 2007-02-21 10:11:26 UTC 
Verified in Milestone 11 of chart2mst3.
Comment 9 bjoern.milcke 2007-05-30 09:43:01 UTC 
Verified in master SRC680_m213.