Issue 71206 - chart2mst3 fails to build on Mac OS X
Summary: chart2mst3 fails to build on Mac OS X
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All Mac OS X, all
: P2 Trivial (vote)
Target Milestone: ---
Assignee: shaunmcdonald131
QA Contact: issues@graphics
URL: http://ooo-staging.osuosl.org:8010/Ma...
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-05 11:11 UTC by shaunmcdonald131
Modified: 2013-02-24 21:20 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description shaunmcdonald131 2006-11-05 11:11:21 UTC
It would appear that there is an issue with the current code in the CWS as it will not compile on Mac OS 
X (Intel, X11). Please see http://ooo-staging.osuosl.org:8010/MacPort1/builds/71 for full details of the 
build.

The affected files are:
svx/svxids.hrc
/svx/source/dialog/optchart.hxx

tail of log:
------------------------------
Making: ../../unxmacxi.pro/slo/optchart.obj
ccache g++ -fsigned-char -fmessage-length=0 -malign-natural -c -O2 -fno-strict-aliasing   -
fvisibility=hidden -DDG_DLL -I.  -I../../unxmacxi.pro/inc/dialogs -I../inc -I../../inc/pch -I../../inc -
I../../unx/inc -I../../unxmacxi.pro/inc -I. -I/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/
buildbot_ooo/MacBookEdin/build/solver/680/unxmacxi.pro/inc/stl -I/Users/ooobuild/ooo-build/
buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/solver/680/unxmacxi.pro/inc/
external -I/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/
build/solver/680/unxmacxi.pro/inc -I/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/
buildbot_ooo/MacBookEdin/build/solenv/unxmacxi/inc -I/Users/ooobuild/ooo-build/buildbot/
buildbot-source/bin/buildbot_ooo/MacBookEdin/build/solenv/inc -I/Users/ooobuild/ooo-build/
buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/res -I/Users/ooobuild/ooo-build/
buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/solver/680/unxmacxi.pro/inc/stl -I/
System/Library/Frameworks/JavaVM.framework/Versions/Current/Headers -I/System/Library/
Frameworks/JavaVM.framework/Headers -I/usr/X11R6/include -I/usr/X11R6/include/freetype2     -I/
Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/solver/
680/unxmacxi.pro/inc/offuh -I. -I../../res -I. -pipe -malign-natural -fsigned-char -Wno-long-double  
-Wno-ctor-dtor-privacy -fexceptions -fno-enforce-eh-specs    -fPIC -fno-common -DMACOSX -
DUNX -DVCL -DGCC -DC300 -DINTEL -DCVER=C300 -DGLIBC=2 -D_PTHREADS -D_REENTRANT -
DNO_PTHREAD_PRIORITY -DX86 -DSTLPORT_VERSION=400 -D_USE_NAMESPACE=1 -DX_LOCALE -
DHAVE_GCC_VISIBILITY_FEATURE -DNO_AUDIO -D__DMAKE -DUNIX -DCPPU_ENV=gcc3 -
DGXX_INCLUDE_PATH=/usr/include/c++/4.0.0 -DSUPD=680 -DPRODUCT -DNDEBUG -
DPRODUCT_FULL -DOSL_DEBUG_LEVEL=0 -DOPTIMIZE -DEXCEPTIONS_ON -DCUI -DSOLAR_JAVA -
DSRC680=SRC680  -DBUILD_OS_APPLEOSX -DBUILD_OS_MAJOR=10 -DBUILD_OS_MINOR=4 -
DBUILD_OS_REV=8 -DSVX_DLLIMPLEMENTATION -DSHAREDLIB -D_DLL_  -DMULTITHREAD  -o ../../
unxmacxi.pro/slo/optchart.o /Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/
MacBookEdin/build/svx/source/dialog/optchart.cxx 
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx:47:26: error: svx/svxids.hrc: No such file or directory
In file included from /Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/
MacBookEdin/build/svx/source/dialog/optchart.cxx:49:
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.hxx:52:27: error: svx/dlgctrl.hxx: No such file or directory
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.hxx:66: error: expected class-name before '{' token
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.hxx: In constructor 'ChartColorLB::ChartColorLB(Window*, ResId)':
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.hxx:68: error: class 'ChartColorLB' does not have any field named 'ColorLB'
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.hxx: In constructor 'ChartColorLB::ChartColorLB(Window*, WinBits)':
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.hxx:69: error: class 'ChartColorLB' does not have any field named 'ColorLB'
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx: In member function 'void ChartColorLB::FillBox(const 
SvxChartColorTable&)':
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx:60: error: 'SetUpdateMode' was not declared in this scope
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx:64: error: 'Append' was not declared in this scope
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx: In constructor 'SvxDefaultColorOptPage::SvxDefaultColorOptPage
(Window*, const SfxItemSet&)':
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx:86: error: 'class ChartColorLB' has no member named 'SetSelectHdl'
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx: In member function 'void SvxDefaultColorOptPage::Construct()':
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx:133: error: 'class ChartColorLB' has no member named 'SelectEntryPos'
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx: In member function 'virtual void SvxDefaultColorOptPage::Reset(const 
SfxItemSet&)':
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx:153: error: 'class ChartColorLB' has no member named 'SelectEntryPos'
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx: In member function 'long int SvxDefaultColorOptPage::ResetToDefaults
(void*)':
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx:204: error: 'class ChartColorLB' has no member named 'Clear'
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx:207: error: 'class ChartColorLB' has no member named 'GetFocus'
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx: In member function 'long int SvxDefaultColorOptPage::ListClickedHdl
(ChartColorLB*)':
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx:218: error: 'class ChartColorLB' has no member named 
'GetSelectEntryColor'
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx: In member function 'long int SvxDefaultColorOptPage::BoxClickedHdl
(ValueSet*)':
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx:239: error: 'class ChartColorLB' has no member named 'GetSelectEntryPos'
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx:240: error: 'LISTBOX_ENTRY_NOTFOUND' was not declared in this scope
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx:243: error: 'class ChartColorLB' has no member named 'GetSelectEntry'
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx:245: error: 'class ChartColorLB' has no member named 'Modify'
/Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/buildbot_ooo/MacBookEdin/build/svx/
source/dialog/optchart.cxx:248: error: 'cla,56:0ss ChartColorLB' has no member named 'SelectEntryPos'
,323:0dmake:  Error code 1, while making '../../unxmacxi.pro/slo/optchart.obj'
'---* tg_merge.mk *---'

ERROR: Error 65280 occurred while making /Users/ooobuild/ooo-build/buildbot/buildbot-source/bin/
buildbot_ooo/MacBookEdin/build/svx/source/dialog
dmake:  Error code 1, while making 'build_instsetoo_native'
'---*  *---'
,37:2program finished with exit code 255
,
Comment 1 bjoern.milcke 2006-11-05 17:17:07 UTC
Looks strange because the error is that a method of a class is not declared. This doesn't look like a MacOS 
only problem. Will check what this could be.
->smsm1: You cc'ed bjm, if you meant me, I am bm.
Comment 2 pavel 2006-11-05 18:56:09 UTC
The problem is that you include the missing file as:

#include <svx/svxids.hrc>

but you should use

#include <svxids.hrc>

instead. It works in HBG because you reuse previously delivered version of this
file where it is stored in svx/, but in the source it is stored in inc/ only,
not in inc/svx/. It is not possible to use previously built file if you build
from scratch.
Comment 3 bjoern.milcke 2006-11-06 09:42:39 UTC
->smsm1: Thanks. I will change the include on the CWS. Cool, that you check the
Mac OS/X version, thanks for that also.
Changed the platform as this is a general problem.
->smsm1: Is it ok for you to close this issue without adding it to the CWS?

I removed the include as it is part of dialogs.hrc. That's also how other
dialogs do that. (BTW., we wouldn't have had the problem, if the dialogs.hrc
would have been before the <svx/svxids.hrc>)

Changed file: svx/source/dialog/optchart.cxx (rev. 1.1.2.3)
Comment 4 bjoern.milcke 2006-11-06 09:44:11 UTC
please verify and close.
Comment 5 shaunmcdonald131 2006-11-07 01:15:10 UTC
Sorry, I cannot verify this issue as being fixed please see 
http://ooo-staging.osuosl.org:8010/MacPort1/builds/73/step-compile/4
where I get pretty much the same error again.

Comment 6 shaunmcdonald131 2006-11-07 01:16:33 UTC
Reopening, since it isn't fixed.
Comment 7 pavel 2006-11-07 05:41:30 UTC
It is the next similar error:

pavel@paveljanik:/tmp/q> grep svx/ CWS-chart2mst3-svx.diff|grep include
...
+#include <svx/dlgctrl.hxx>
pavel@paveljanik:/tmp/q> 

bm: consider rebuilding chart2mst3 from scratch. You build it in environment,
which contains dlgctrl.hxx already delivered from the previous build in solver.
You can't include files from solver before delivering it.

Shaun: This is the last instance of it in module svx ;-)
Comment 8 bjoern.milcke 2006-11-07 09:11:03 UTC
I checked in the changed optchart.hxx. Sorry for the inconvenience. This should
be the last occurence of an <svx/...> include in svx, except those that refer to
the local svx/inc/svx/...

The affected code was copied from the sch project, where the svx/ was needed.
Since it is now in svx itself, the svx/ must be ommited. There were only these
two places.

Please verify again.
Comment 9 bjoern.milcke 2006-11-07 09:19:22 UTC
->pjanik: A complete build from scratch on our local CWS is difficult, as we do
not have all project sources locally (some projects are linked read-only).
Unlinking would be tedious, as we have no good tools for that.

Doing a complete CWS build in a "sandbox" also takes time that I don't want to
spend, especially as obviously, thankfully Shaun does a complete build :-) I
suppose the kind of problem we had is really specific to the moved code from
sch. If it turns out that we have more problems because of an existing solver,
we can re-consider.
Comment 10 shaunmcdonald131 2006-11-09 00:29:36 UTC
This is now fixed.
Please see
http://ooo-staging.osuosl.org:8010/MacPort1/builds/74
for the build log, and a download of this build for Mac OS X Intel. (There are some extra files in the tar 
archive, that can just be ignored). Only unxmacxi.pro/OpenOffice/install/en-US/
OpenOffice.org-2.1.0_en-US.dmg needs to be released, if this build is to be used for releasing with the 
other builds for this CWS < http://blogs.sun.com/bmilcke/entry/chart2_beta_build_respin_available >. 
(Sorry I cannot build for PPC)
Comment 11 pavel 2006-11-09 07:44:53 UTC
ok, closing.