Issue 75865 - DTD: Unexpected Choice chart:bar for attribute chart:class
Summary: DTD: Unexpected Choice chart:bar for attribute chart:class
Status: CLOSED WONT_FIX
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P2 Trivial (vote)
Target Milestone: ---
Assignee: michael.brauer
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks: 75528 75529
  Show dependency tree
 
Reported: 2007-03-29 14:29 UTC by frank
Modified: 2013-02-24 21:19 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
bugdoc (9.14 KB, application/vnd.sun.xml.calc)
2007-03-29 14:31 UTC, frank 		no flags Details
Fix for this bug in xmloff (1.42 KB, patch)
2007-04-02 17:53 UTC, bjoern.milcke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description frank 2007-03-29 14:29:47 UTC 
Validate the content.xml extracted from the Object 1 directory of the unzipped
bugdoc and validate it against the DTD.

You will get an error stating 'Unexpected Choice chart:bar for attribute
chart:class'

Frank
Comment 1 frank 2007-03-29 14:30:29 UTC 
targeted
Comment 2 frank 2007-03-29 14:31:40 UTC 
Created attachment 44020 [details]
bugdoc
Comment 3 frank 2007-03-29 14:44:22 UTC 
.
Comment 4 bjoern.milcke 2007-03-30 14:42:25 UTC 
If we extend binfilter to understand the class attribute at data-series (to fix
Issue 75528 and Issue 75529), we need to fix this.
Comment 5 bjoern.milcke 2007-04-02 17:49:29 UTC 
The transformation between OOo and ODF adds/removes a namespace "chart:" at the
chart:class attribute of the chart:chart element. This transformation is missing
for the chart:series element.

When this issue is fixed, files in OOo (e.g. ".sxc") format created with
StarOffice 7.0 (OOo 1.1) or StarOffice 8 (OOo 2) containing stock charts of
types 3 or 4 (with volume) will not import correctly. And the other way round,
that is files created with the fixed version will load incorretly in the
aforementioned versions.

Stock charts of type 1 or 2, and combi-charts with bars and lines will import
correctly between the versions.

->MIB: What do you think about the impact this has? If we don't fix this issue,
we have to add a namespace in binfilter to conform to the "non-conforming" OOo
format that is currently implemented.
Comment 6 bjoern.milcke 2007-04-02 17:53:51 UTC 
Created attachment 44166 [details]
Fix for this bug in xmloff
Comment 7 bjoern.milcke 2007-04-02 17:57:03 UTC 
(Note: The reason why the combi chart still works but the stock chart doesn't
is, that the combi-chart prefers the "lines-used" property, but the stock chart
import prefers the chart:class="chart:bar" (with the wrong namespace) over the
property "stock-with-volume")
Comment 8 bjoern.milcke 2007-04-03 08:48:30 UTC 
This issue seems to risky to me to fix. It breaks old files and leads to new
files that conform the DTD but will be read incorrectly by old versions. I don't
really see the benefit.

If this issue will be fixed, we will need an additional fix in binfilter in
binfilter/bf_xmloff/source/chart/xmloff_SchXMLExport.cxx In the beginning of the
file there is a commented-out macro defined ISSUE_75865_IS_FIXED. This macro has
to be enabled to apply a different behaviour that conforms to the fix made in
xmloff (see patch).
Comment 9 bjoern.milcke 2007-04-03 08:55:03 UTC 
(Addition to previous note: the macro will be available after integration of CWS
OOF680/oasisrng02)

->FST: See my comments before for the reasoning to fix this. A fix exists (see
attachment), but it breaks some OOo files (with stock-charts of type 3 and 4).
Comment 10 frank 2007-04-30 14:04:42 UTC 
Hi Michael,

what's your point of view here ? If you vote for closing, please do so.

Frank
Comment 11 michael.brauer 2007-07-09 08:56:00 UTC 
I also do not see any benefit in resolving that.