Issue 89331 - chart2: patch to remove unused code
Summary: chart2: patch to remove unused code
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: caolanm
QA Contact: issues@graphics
URL:
Keywords: oooqa
Depends on:
Blocks:
 
Reported: 2008-05-12 13:35 UTC by caolanm
Modified: 2013-02-24 21:20 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
patch to remove unused code (283.43 KB, patch)
2008-05-12 13:36 UTC, caolanm
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2008-05-12 13:35:42 UTC
As shown in http://people.redhat.com/caolanm/callcatcher/DEV300_m12/ there are
104 unused methods in chart2. The following patch removes 103 of them saving
228k (for my x86_64 pro libs)
Comment 1 caolanm 2008-05-12 13:36:14 UTC
Created attachment 53564 [details]
patch to remove unused code
Comment 2 kla 2008-05-13 06:15:32 UTC
@IHA: PLease have a look. Thx
Comment 3 caolanm 2008-05-13 08:25:44 UTC
oh forgot to mention that the following files can then be cvs deleted

source/model/main/DataPointStyle.cxx
source/model/main/DataPointStyle.hxx
source/tools/OIndexContainer.cxx
source/inc/OIndexContainer.hxx
source/inc/OEnumeration.hxx
source/tools/OEnumeration.cxx
source/controller/chartapiwrapper/WrappedNamedProperty.hxx
source/controller/chartapiwrapper/WrappedNamedProperty.cxx
source/model/main/DataSeriesStyle.cxx
source/model/main/DataSeriesStyle.hxx
source/tools/OStyle.cxx
source/inc/OStyle.hxx
source/model/main/StyleFamily.cxx
source/model/main/StyleFamily.hxx
source/model/main/StyleFamilies.cxx
source/model/main/StyleFamilies.hxx
source/tools/ContextHelper.cxx
source/inc/ContextHelper.hxx
Comment 4 IngridvdM 2008-06-04 12:52:34 UTC
I think this are too much changes now so short before code freeze for 3.0
->change target
Comment 5 IngridvdM 2008-09-02 15:51:25 UTC
Fixed in CWS chart30.
Comment 6 IngridvdM 2008-09-03 14:59:59 UTC
iha->cmc, please verify in CWS chart30.
Comment 7 caolanm 2008-09-03 15:13:43 UTC
seems fine
Comment 8 caolanm 2008-10-09 10:47:58 UTC
Seen in m33