Apache OpenOffice (AOO) Bugzilla – Issue 90071
display of charts with clipped data crashes office
Last modified: 2013-02-24 21:20:09 UTC
- open the attached spreadsheet document - press Backspace in an empty cell, to mark the document modified - save the document (Ctrl+S) - press Backspace in an empty cell, to mark the document modified - save the document (Ctrl+S) => OOo crashs (no crash reporter) Actually, this only one of multiple ways how I managed to crash OOo with this document. Nearly every attempt to save the document crashes, which makes editing it up to impossible - all changes done are lost in the next save attempt. Another possibility to crash, with the same document: - open the document - right-click onto the "Ø 2007" sheet - choose "Delete Sheet" from the sheet's context menu => note the sheet "W" becomes current - left-click onto the "Ø 2008" sheet to activate it => the sheet is not painted. Actually, it seems painting completely stopped in the document, as you can see when you minimize and restore the document window - with the mouse, click the "Open File" button in the main toolbar => crash
Created attachment 54021 [details] document to reproduce the bug case
The problem is a regression between 2.3.1 and 2.4 => keyword "regression", P2, target OOo 3.0. Note I am going to nominate this as blocker for 2.4.1. The bug makes working with this particular document, and perhaps with a whole class of documents, effectively impossible.
It's a Chart problem (Clipping::clipPolygonAtRectangle, lcl_addPointToPoly). That code was changed for issue 66963.
Created attachment 54030 [details] Fix for this issue in module chart2
Attached a fix for this issue. The fix is straight-forward. It was obviously a memory allocation problem. With the fix, the crash no longer appears. However I haven't checked thoroughly that the document is correct. On first sight it is. As the fix is in the view-code it does not affect the chart model, i.e. load and save should not be affected. ->FST: Please check how to proceed. If this becomes a 2.4.1 issue this issue should get an according target or a duplicated one with this target. Maybe it makes sense to add this issue to an existing 2.4.1 CWS in that case, what do you think?
This came in with CWS chart15 (chart15_OOH680) in the fix for Issue 66963.
added MH to CC
I checked the patch from Björn and suggest a small change to be sure that the added integers are properly initialized with zero. I'll attach the corrected patch.
Created attachment 54209 [details] safe patch
I checked issue 66963 with the fix and it is ok, so no reopening to fear there. This problem can in principle occur for line-charts, area-charts, xy-charts and net charts when not all data points are shown. As an access to an uninitialized variable is involved the symptoms of the problem can be different. I have seen crashes and not properly repainting charts also. I would estimate that this problem does occur often. I further would estimate that the fix is safe enough to take it for OOo 2.4.1 even now.
Fixed in CWS chart27 for OOo 3.0.
*** Issue 88894 has been marked as a duplicate of this issue. ***
I changed the summary to be more informative, because the problem has nothing to do with saving but instead with the display of charts with clipped data.
Also fixed in CWS chart28 for OOo 2.4.1 Setting target to 2.4.1 to fulfill CWS handling requirements thus the CWS can be tested.
@Thomas, please verify in CWS chart28.
verified. Works fine with the attached doc and also with the documents attached at 66963 and 88894.
The fix for this issue was integrated to dev300m20 via chart28_DEV300 clone. So i can remove the issue from CWS chart27.
*** Issue 90943 has been marked as a duplicate of this issue. ***
The integration of this fix to OOo 2.4.1. was refused. So I change the target to 2.4.2. The fix was instead integrated into the 3.0 code line starting with DEV300m20. For other reasons I cannot recommend version DEV300m20 for use with charts, so please use dev300m23 or newer.
Seen ok in current master -> closed