Issue 90931 - wrong type and value for property FillGradientStepCount
Summary: wrong type and value for property FillGradientStepCount
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: bjoern.milcke
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-20 15:13 UTC by IngridvdM
Modified: 2013-02-24 21:21 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
bugdoc to verify the property (16.15 KB, application/vnd.oasis.opendocument.spreadsheet)
2008-06-25 09:48 UTC, bjoern.milcke 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description IngridvdM 2008-06-20 15:13:03 UTC 
The UNO API property 'FillGradientStepCount' is defined as sal_Int16.
The im- and export in xmloff should respect that also. sal_Int32 is used falsely
so far which leads to an assertion in chart when compiled with debug.
Moreover the default value in chart for the GradientStepCount is illegal as it
is zero and zero is not an allowed value in the ODF 1.2 specification for the
'gradient-step-count' property.
Comment 1 IngridvdM 2008-06-20 15:28:42 UTC 
Changed type from XML_TYPE_NUMBER to XML_TYPE_NUMBER16 in
xmloff/source/draw/sdpropls.cxx.
Removed wrong property default '0' in
chart2/source/model/main/DataPointProperties.cxx
and chart2/source/tools/FillProperties.cxx
and made the property ::MAYBEVOID.
Comment 2 IngridvdM 2008-06-23 16:28:30 UTC 
@Bjoern, please verify in CWS chart27. Thanks!
Comment 3 bjoern.milcke 2008-06-25 09:48:38 UTC 
Created attachment 54726 [details]
bugdoc to verify the property
Comment 4 bjoern.milcke 2008-06-25 10:02:22 UTC 
the property is void by default now. After setting it becomes an Integer in Basic. Which corresponds to 
sal_Int16.

So the change in xmloff is correct. Verified in the source code.
Comment 5 thorsten.ziehm 2009-07-20 15:55:25 UTC 
This issue is closed automatically and wasn't rechecked in a current version of
OOo. The fixed issue should be integrated in OOo since more than half a year. If
you think this issue isn't fixed in a current version (OOo 3.1), please reopen
it and change the field 'Target Milestone' accordingly.

If you want to download a current version of OOo =>
http://download.openoffice.org/index.html
If you want to know more about the handling of fixed/verified issues =>
http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues