Issue 97563 - Incorrect number format export in odf chart export & wrong assertion
Summary: Incorrect number format export in odf chart export & wrong assertion
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: oc
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-24 21:11 UTC by kyoshida
Modified: 2013-02-24 21:20 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch to remove assertions (1.80 KB, patch)
2008-12-24 21:12 UTC, kyoshida 		no flags Details | Diff
patch to remove assertions (1.80 KB, patch)
2008-12-24 21:12 UTC, kyoshida 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description kyoshida 2008-12-24 21:11:27 UTC 
When built with --enable-dbgutil, the chart triggers the following two debug
assertion messages

* no existing Numberformat found with this key
* not enough data points

when creating a new pie chart in Calc with arbitrary data set, and clicking
outside the chart object to bring focus back to Calc.

Reading up the code a bit, it appears that, within
SchXMLExportHelper::exportDataPoints(), the code tries to export a number format
when in fact the object only has a color attribute, and tries to use the color
value as the number format key which triggers the first assertion.

The second assertion is triggered when the bExportContent boolean value is
false, which leads to the data point list to remain empty.  I believe the
assertion should be checked only when the bExportContent bit is true.

My patch will fix these two issues.
Comment 1 kyoshida 2008-12-24 21:12:19 UTC 
Created attachment 59000 [details]
patch to remove assertions
Comment 2 kyoshida 2008-12-24 21:12:41 UTC 
Created attachment 59001 [details]
patch to remove assertions
Comment 3 kyoshida 2008-12-24 21:15:28 UTC 
sorry about the duplicate.  The web interface was malfunctioning and I got an
empty page after the patch upload. :-(

Anyway, could either bm or lha review this patch to see if this is safe?  I
believe this is a safe change, but I just want to make sure it really is.

Thanks!
Comment 4 kyoshida 2009-01-08 17:28:42 UTC 
@bm, iha: can one of you have a quick look and see what you think?  If this
looks good, then I can take care of integrating it in one of my open CWSes.
Comment 5 bjoern.milcke 2009-01-13 11:57:23 UTC 
->IHA: Please have a look
Comment 6 IngridvdM 2009-01-13 14:18:36 UTC 
@kohei, the patch looks fine!
Comment 7 kyoshida 2009-01-13 14:21:19 UTC 
@iha: thanks Ingrid, for your review. :-)
Comment 8 kyoshida 2009-01-20 15:59:07 UTC 
fixed in koheiformula02 cws.
Comment 9 kyoshida 2009-01-26 22:26:31 UTC 
re-assigning to oc for qa.
Comment 10 kyoshida 2009-01-26 22:26:43 UTC 
re-assigning to oc for qa.
Comment 11 oc 2009-02-11 13:57:28 UTC 
verified in internal build cws_koheiformula02
Comment 12 thorsten.ziehm 2010-02-22 15:33:20 UTC 
This issue is closed automatically. It should be fixed in a version with is
available for longer than half a year (OOo 3.1). If you think this issue isn't
fixed in the current version (OOo 3.2) please reopen it. But then please pay
attention about the field 'target milestone'.
The closure was approved by the Release Status Meeting at 22nd of February 2010
and it is based on the issue handling guideline for fixed/verified issues :
http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues