Issue 99721 - chart2: patch to remove unused code
Summary: chart2: patch to remove unused code
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: caolanm
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-27 15:35 UTC by caolanm
Modified: 2013-02-24 21:21 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
unused code in chart2 (22.09 KB, patch)
2009-02-27 15:35 UTC, caolanm 		no flags Details | Diff
remove getbottom (1.70 KB, patch)
2009-04-02 12:16 UTC, caolanm 		no flags Details | Diff
make singletop a local static instead of a heap allocated object, equally thread unsafe as current, but dtor call be called in theory on dlclose (1.34 KB, patch)
2009-04-02 12:18 UTC, caolanm 		no flags Details | Diff
more attractive solution using rtl::Static (3.56 KB, patch)
2009-04-02 12:18 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2009-02-27 15:35:34 UTC 
Attached is a patch to remove (or if 0 when the only reference to it is also
commented out) the current set of unused code in chart2
Comment 1 caolanm 2009-02-27 15:35:59 UTC 
Created attachment 60553 [details]
unused code in chart2
Comment 2 IngridvdM 2009-03-04 13:46:32 UTC 
I will have a look at this after finishing some other patches. Thanks!
Comment 3 IngridvdM 2009-03-24 17:01:47 UTC 
@cmc, thanks! I've commited the patch to CWS chart37.
Comment 4 IngridvdM 2009-04-01 13:58:45 UTC 
@cmc, please verify in CWS chart37.
Comment 5 caolanm 2009-04-02 12:16:09 UTC 
All good, but afterwards there are two new unused methods introduced since the
original patch. Do you want to handle them now or leave them until later ?

i.e. TextSeparatorResources::getBottom is unused (patch to be attached) and the
singletop ConfigurationAccess's dtor is uncallable (fixable in two ways, both
options to-be attached)
Comment 6 caolanm 2009-04-02 12:16:47 UTC 
Created attachment 61359 [details]
remove getbottom
Comment 7 caolanm 2009-04-02 12:18:02 UTC 
Created attachment 61360 [details]
make singletop a local static instead of a heap allocated object, equally thread unsafe as current, but dtor call be called in theory on dlclose
Comment 8 caolanm 2009-04-02 12:18:58 UTC 
Created attachment 61361 [details]
more attractive solution using rtl::Static
Comment 9 IngridvdM 2009-04-02 13:36:40 UTC 
Thanks! I have commited getbottom.patch and dtor2.patch to CWS chart37.
Comment 10 caolanm 2009-04-02 15:33:22 UTC 
verified, 0 unused methods, neato
Comment 11 caolanm 2009-06-11 09:52:47 UTC 
http://people.redhat.com/caolanm/callcatcher/DEV300_m50/ shows 0 unused methods
in chart2