Issue 76802 - new chart: value "phong" of dr3d:shade-mode behaviour differs from specification
Summary: new chart: value "phong" of dr3d:shade-mode behaviour differs from specification
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: jogi
QA Contact: issues@graphics
URL: http://specs.openoffice.org/chart/Cha...
Keywords: new_implementation
Depends on:
Blocks:
 
Reported: 2007-04-30 10:02 UTC by jogi
Modified: 2013-02-24 21:20 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
dr3d:shade-mode:"phong" set in "Object 1/context.xml" (18.36 KB, application/vnd.oasis.opendocument.spreadsheet)
2007-04-30 10:04 UTC, jogi
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description jogi 2007-04-30 10:02:49 UTC
In the 3D View specification under chapter "4.2.1 Shading" in line 121: "The
phong shading is interpreted as gouraud shading and cannot be set in the user
interface anymore."

I have created a testcase:
1. Save a chart in a spreadsheet from CWS:Chart2Mst3 where the shading is
enabled (Realistic)
2. Manipulate the dr3d:shade-mode="gouraud" to dr3d:shade-mode="phong" in
"Object 1/content.xml"
3. Replace the original "Object 1/content.xml" in the compressed
document-container with the manipulated one
4. Load the document in the CWS:chart2mst3 office (patched)
5. Activate the chart object (Call Navigator [F5] -> Select the 1st OLE [RETURN]
-> Edit / Object / Edit)
6. Format / 3D View
7. Select the "Appearance" tab page

Results:
- The check-box "shading" is disabled  (Bug)
- the "Scheme" is "Custom" (Bug)
  See spec: "phong" value should be interpreted as "gouraud" and that would be
"Realistic" 
  scheme and "shading" has to be checked in all cases ("Custom" or "Realistic").
- If the file is being saved now the "phong" value isn't being replaced by
"gouraud" in the file
 format. (Bug)

@IHA: you can fix one after another in different issues but all things are in
context. Don't know what you prefer.
Comment 1 jogi 2007-04-30 10:04:59 UTC
Created attachment 44771 [details]
dr3d:shade-mode:"phong" set in "Object 1/context.xml"
Comment 2 jogi 2007-04-30 10:05:56 UTC
Kyesword set
Comment 3 bjoern.milcke 2007-05-02 12:24:36 UTC
Matthias just said: Keep the alerts when the minimum ia larger than the maximum.
The spec contains a new alert text.
Comment 4 bjoern.milcke 2007-05-02 15:11:57 UTC
Forget last comment, was intended for Issue 76842
Comment 5 IngridvdM 2007-05-04 10:55:43 UTC
I changed the specification:
http://specs.openoffice.org/chart/Chart3DViewDialog.odt
line 124-126: changed description for case phong shading
line 47: changed condition 'while shading is on' to 'while shading is not off'

This should resolve the conflicts with the current implementation.


Comment 6 IngridvdM 2007-05-04 10:58:07 UTC
->Jogi: The updated specification is online, please verify.
Comment 7 jogi 2007-05-07 12:33:07 UTC
ok
Comment 8 jogi 2007-05-07 12:33:37 UTC
closing