Issue 79013 - Do range verification in range dialogs correctly
Summary: Do range verification in range dialogs correctly
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: kla
QA Contact: issues@graphics
URL:
Keywords:
: 79268 (view as issue list)
Depends on:
Blocks:
 
Reported: 2007-06-29 12:58 UTC by bjoern.milcke
Modified: 2013-02-24 21:19 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description bjoern.milcke 2007-06-29 12:58:09 UTC 
In the edit fields of the Data Ranges dialog where you can enter cell-ranges
from Calc or Writer, there should be a verification mechanism that disables the
dialog confirmation in exactly those cases when creation is not possible.

For this purpose I extended the interface css::chart2::data::XDataProvider by
the two methods createDataSourcePossible and
createDataSequenceByRangeRepresentationPossible() that should return true in
exactly those cases where the methods without "Possible" would return a valid
object (and not throw an IllegalArgumentException).

->TL, NN: Please implement the functions for which I prepared a
dummy-Implementation (for the sake of compilability) in CWS chart07.
Comment 1 bjoern.milcke 2007-06-29 12:59:46 UTC 
Added tl and nn to CC.
Comment 2 bjoern.milcke 2007-07-05 09:52:53 UTC 
Interface added in CWS07. Chart uses it for verification.
Comment 3 bjoern.milcke 2007-07-05 09:54:03 UTC 
s/CWS07/CWS chart07/
Comment 4 thomas.lange 2007-07-12 12:44:39 UTC 
*** Issue 79268 has been marked as a duplicate of this issue. ***
Comment 5 thomas.lange 2007-07-12 13:31:16 UTC 
TL: Fixed for sw.

Files changed:
- sw/inc/unochart.hxx
- sw/source/core/unocore/unochart.cxx
Also merged changes from CWS tl39 into this CWS.
Comment 6 bjoern.milcke 2007-07-13 09:31:36 UTC 
->nn: please implement for Calc.
Comment 7 bjoern.milcke 2007-07-13 09:43:23 UTC 
->TL: Just noticed that "Table1.A1:A4xxxxxxxx" is detected as valid. Maybe this
should be invalid.
Comment 8 thomas.lange 2007-07-13 12:06:32 UTC 
TL->BM: problem with cell names like "A4x" fixed.

Files changed:
- sw/source/core/table/swtable.cxx
Comment 9 niklas.nebel 2007-07-13 16:32:30 UTC 
Implemented in Calc (chart2uno.cxx 1.7.24.2).
Comment 10 niklas.nebel 2007-07-16 11:24:28 UTC 
Reassigning to QA for verification.
Comment 11 kla 2007-07-18 09:39:48 UTC 
verified
Comment 12 p9w.vu.31122010 2007-09-27 10:52:16 UTC 
verified fixed in m230, closing.