Issue 79531 - chart2: failed range verification in range dialogs should not disable controls
Summary: chart2: failed range verification in range dialogs should not disable controls
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-12 13:46 UTC by thomas.lange
Modified: 2013-02-24 21:19 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description thomas.lange 2007-07-12 13:46:16 UTC 
With the fix for issue 79013 in sw it became apparent that the 4 controls of the
range dialog should not be disabled if the range check fails.
The reason for this is that just a change of e.g. the source direction from cols
to rows may result in the same data range being acceptable now.

Currently it is not able to change any of the 4 controls if the range was found
invalid.

For a sample case and document have a look in issue 79268.
Comment 1 thomas.lange 2007-07-12 13:46:39 UTC 
.
Comment 2 bjoern.milcke 2007-07-12 14:51:13 UTC 
Changing to TASK as this was no requirement yet.

Note: this change may affect automated tests.
Comment 3 bjoern.milcke 2007-07-13 07:50:21 UTC 
It violates the spec and therefore breaks the auto tests. So this can not be
done for OOo 2.3. We have to reconsider this issue for 2.4.

Meanwhile we should at least handle this situation:
* you have a valid range
* you click one of the checkboxes or radio buttons -> the range becomes invalid
* you can't get back as the controls are disabled.

Solution: disable all buttons that would render the range invalid.
Comment 4 thomas.lange 2007-07-13 07:53:52 UTC 
Violation of the spec is no reason to postpone this. Please ask to have the spec
changed since the behavior is quite inconvenient to the user.
Comment 5 bjoern.milcke 2007-07-13 09:22:07 UTC 
Fixed it this way. A checkbox/radiobutton is disabled when after clicking it,
the range would be verified as invalid. Checking auto-tests.
Comment 6 bjoern.milcke 2007-07-16 10:25:03 UTC 
Please verify in CWS chart07.

Check that changing the radio buttons and check boxes do not lead to an invalid
range (when it was valid before).
Comment 7 kla 2007-07-19 14:04:56 UTC 
@mru: one for you.
Comment 8 michael.ruess 2007-07-19 14:42:20 UTC 
Verified in CWS chart07.
Comment 9 michael.ruess 2007-08-02 10:52:57 UTC 
Checked in 680m224.